MSVC Warning cleanup, /WX (Werror), and misc. fixes #790
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
C4100: unreferenced formal parameter C4013: call to an undefined function
mrannanj
approved these changes
Nov 26, 2024
katajakasa
reviewed
Nov 26, 2024
| @@ -7,7 +7,7 @@ static GLuint bound_vbo = 0; | |||
| static GLuint bound_vao = 0; | |||
| static GLuint bound_tex[] = {0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0}; | |||
| static GLuint bound_fbo = 0; | |||
| static GLuint active_tex = -1; | |||
| static GLuint active_tex = ~0u; | |||
There was a problem hiding this comment.
It is fine to set this to just 0, since GL_TEXTURE0 is the default.
There was a problem hiding this comment.
-1 must have been some sort of remnant from somewhere ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enabling and fixing C4668 may be a bit silly, but I was feeling guilty about my habit of writing
#if XYZinstead of#ifdef XYZ(where XYZ is maybe-defined, like __APPLE__)implicit lossy conversions
The following two warnings are now be disabled, and are comparable to GCC's -Wconversion; -Wconversion is not enabled on master branch. Banning implicit lossy conversions is a good idea for another time, but fixing them will generate a lot of line diff noise.